Fix: get things running again.

.rubocop.yml

@@ -10,10 +10,6 @@ AllCops:
 Layout/LineLength:
   Enabled: false
 
-# One case statement in a single method isn't complex.
-Metrics/CyclomaticComplexity:
-  IgnoredMethods: ['case']
-
 # 10 is a good goal but a little draconian
 Metrics/MethodLength:
   CountAsOne: ['array', 'hash', 'heredoc']

Gemfile

@@ -6,3 +6,20 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'rake', '~> 13.0'
+
+group :development do
+  gem 'bundler-audit'
+  gem 'codecov'
+  gem 'flay'
+  gem 'flog'
+  gem 'inch'
+  gem 'minitest'
+  gem 'minitest-heat'
+  gem 'psych'
+  gem 'reek'
+  gem 'rubocop'
+  gem 'rubocop-minitest'
+  gem 'rubocop-rake'
+  gem 'simplecov'
+  gem 'yard'
+end

lib/reviewer/command/string/env.rb

@@ -30,7 +30,7 @@ def to_a
         def env(key, value)
           return nil if key.to_s.strip.empty? || value.to_s.strip.empty?
 
-          value = needs_quotes?(value) ? "'#{value}'" : value
+          value = "'#{value}'" if needs_quotes?(value)
 
           "#{key.to_s.strip.upcase}=#{value.to_s.strip}"
         end

lib/reviewer/command/string/flags.rb

@@ -37,7 +37,7 @@ def to_a
         def flag(key, value)
           dash = key.to_s.size == 1 ? '-' : '--'
 
-          value = needs_quotes?(value) ? "'#{value}'" : value
+          value = "'#{value}'" if needs_quotes?(value)
 
           "#{dash}#{key} #{value}".strip
         end

lib/reviewer/output.rb

@@ -10,7 +10,7 @@ module Reviewer
   # Friendly API for printing nicely-formatted output to the console
   class Output
     DEFAULT_CONSOLE_WIDTH = 120
-    DIVIDER = '·'
+    DIVIDER = '.'
 
     attr_reader :printer
 

lib/reviewer/runner/strategies/captured.rb

@@ -80,7 +80,11 @@ def display_progress(command, &block) # rubocop:disable Metrics/AbcSize
         #
         # @return [Boolean] true if either stdout or stderr contain printable content
         def usable_output_captured?
-          [runner.stdout, runner.stderr].reject { |value| value.nil? || value.strip.empty? }.any?
+          [runner.stdout, runner.stderr].reject do |value|
+            value.nil? || value.strip.empty?
+          end.any?
+        rescue Encoding::CompatibilityError
+          false
         end
 
         # Prints "Success" and the resulting timing details before moving on to the next tool

reviewer.gemspec

@@ -33,19 +33,4 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'rainbow'
   spec.add_dependency 'slop'
-
-  spec.add_development_dependency 'bundler-audit'
-  spec.add_development_dependency 'codecov'
-  spec.add_development_dependency 'flay'
-  spec.add_development_dependency 'flog'
-  spec.add_development_dependency 'inch'
-  spec.add_development_dependency 'minitest'
-  spec.add_development_dependency 'minitest-heat'
-  spec.add_development_dependency 'psych'
-  spec.add_development_dependency 'reek'
-  spec.add_development_dependency 'rubocop'
-  spec.add_development_dependency 'rubocop-minitest'
-  spec.add_development_dependency 'rubocop-rake'
-  spec.add_development_dependency 'simplecov'
-  spec.add_development_dependency 'yard'
 end

test/reviewer/arguments/files_test.rb

@@ -4,7 +4,7 @@
 
 module Reviewer
   class Arguments
-    class FilesTest < MiniTest::Test
+    class FilesTest < Minitest::Test
       def test_array_casting
         assert_equal [], Files.new.to_a
         assert_equal ['*.css', '*.rb'], Files.new(provided: ['*.rb', '*.css'], keywords: []).to_a

test/reviewer/arguments/keywords_test.rb

@@ -4,7 +4,7 @@
 
 module Reviewer
   class Arguments
-    class KeywordsTest < MiniTest::Test
+    class KeywordsTest < Minitest::Test
       def test_initializes_from_multiple_argument_formats
         keywords = Keywords.new('one')
         assert_equal ['one'], keywords.provided

test/reviewer/arguments/tags_test.rb

@@ -4,7 +4,7 @@
 
 module Reviewer
   class Arguments
-    class TagsTest < MiniTest::Test
+    class TagsTest < Minitest::Test
       def test_array_casting
         assert_equal [], Tags.new.to_a
         assert_equal %w[css html ruby], Tags.new(provided: %w[css], keywords: %w[ruby html]).to_a

test/reviewer/arguments_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 module Reviewer
-  class ArgumentsTest < MiniTest::Test
+  class ArgumentsTest < Minitest::Test
     def test_has_an_empty_array_of_tags_by_default
       args = %w[]
       arguments = Arguments.new(args)

test/reviewer/batch_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 module Reviewer
-  class BatchTest < MiniTest::Test
+  class BatchTest < Minitest::Test
     def setup
       @result = nil
     end

test/reviewer/command/string/env_test.rb

@@ -5,7 +5,7 @@
 module Reviewer
   module Commands
     class String
-      class EnvTest < MiniTest::Test
+      class EnvTest < Minitest::Test
         def setup
           @env_pairs = {
             environment: 'production',

test/reviewer/command/string/flags_test.rb

@@ -5,7 +5,7 @@
 module Reviewer
   class Command
     class String
-      class FlagsTest < MiniTest::Test
+      class FlagsTest < Minitest::Test
         def setup
           @flag_pairs = {
             f: true,

test/reviewer/command/string_test.rb

@@ -4,7 +4,7 @@
 
 module Reviewer
   class Command
-    class StringTest < MiniTest::Test
+    class StringTest < Minitest::Test
       def setup
         @settings = ::Reviewer::Tool::Settings.new(:enabled_tool)
       end

test/reviewer/command_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 module Reviewer
-  class CommandTest < MiniTest::Test
+  class CommandTest < Minitest::Test
     def setup
       @command = Reviewer::Command.new(:enabled_tool, :review)
     end

test/reviewer/conversions_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 module Reviewer
-  class ConversionsTest < MiniTest::Test
+  class ConversionsTest < Minitest::Test
     include Conversions
 
     def test_tool_from_tool_instance

test/reviewer/guidance_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 module Reviewer
-  class GuidanceTest < MiniTest::Test
+  class GuidanceTest < Minitest::Test
     def setup
       @output = Output.new
     end

test/reviewer/history_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 module Reviewer
-  class HistoryTest < MiniTest::Test
+  class HistoryTest < Minitest::Test
     def setup
       @history = History.new
     end

test/reviewer/keywords/git/staged_test.rb

@@ -16,7 +16,7 @@ def exitstatus
         end
       end
 
-      class StagedTest < MiniTest::Test
+      class StagedTest < Minitest::Test
         def test_lists_staged_files_via_class_method
           assert_equal Staged.new.list, Staged.list
         end
@@ -26,8 +26,10 @@ def test_lists_staged_files
         end
 
         def test_parses_empty_git_command_output
+          # rubocop:disable Style/EmptyHeredoc
           empty_staged_files_list = <<~EMPTY_GIT_OUTPUT
           EMPTY_GIT_OUTPUT
+          # rubocop:enable Style/EmptyHeredoc
 
           # Instead of staging files, stub the Open3 call.
           Open3.stub :capture3, [empty_staged_files_list, nil, ProcessStatus.new(true)] do

test/reviewer/loader_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 module Reviewer
-  class LoaderTest < MiniTest::Test
+  class LoaderTest < Minitest::Test
     def test_reads_the_yaml_configuration_file
       loader = Loader.new
       assert loader.configuration.is_a? Hash

test/reviewer/output/printer_test.rb

@@ -4,7 +4,7 @@
 
 module Reviewer
   class Output
-    class PrinterTest < MiniTest::Test
+    class PrinterTest < Minitest::Test
       def setup
         @printer = Printer.new
       end

test/reviewer/output/scrubber_test.rb

@@ -4,7 +4,7 @@
 
 module Reviewer
   class Output
-    class ScrubberTest < MiniTest::Test
+    class ScrubberTest < Minitest::Test
       def test_scrubs_rake_aborted_content
         raw_stderr = <<~STDERR
           some text before

test/reviewer/output_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 module Reviewer
-  class OutputTest < MiniTest::Test
+  class OutputTest < Minitest::Test
     def setup
       @output = Output.new
     end

test/reviewer/runner/strategies/captured_test.rb

@@ -5,7 +5,7 @@
 module Reviewer
   class Runner
     module Strategies
-      class CapturedTest < MiniTest::Test
+      class CapturedTest < Minitest::Test
         def setup
           @strategy = Runner::Strategies::Captured
         end

test/reviewer/runner/strategies/passthrough_test.rb

@@ -5,7 +5,7 @@
 module Reviewer
   class Runner
     module Strategies
-      class PassthroughTest < MiniTest::Test
+      class PassthroughTest < Minitest::Test
         def setup
           @strategy = Runner::Strategies::Passthrough
         end

test/reviewer/runner_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 module Reviewer
-  class RunnerTest < MiniTest::Test
+  class RunnerTest < Minitest::Test
     def test_determines_success_based_on_configured_max_exit_status_for_review
       runner = Runner.new(:enabled_tool, :review)
       max_exit_status = 3

test/reviewer/shell/result_test.rb

@@ -4,7 +4,7 @@
 
 module Reviewer
   class Shell
-    class ResultTest < MiniTest::Test
+    class ResultTest < Minitest::Test
       def setup
         @process_status = MockProcessStatus.new(exitstatus: 0, pid: 123)
       end

test/reviewer/shell/timer_test.rb

@@ -4,7 +4,7 @@
 
 module Reviewer
   class Shell
-    class TimerTest < MiniTest::Test
+    class TimerTest < Minitest::Test
       def test_records_prep_time
         timer = Timer.new
         assert timer.prep.nil?

test/reviewer/shell_test.rb

@@ -3,7 +3,7 @@
 require 'test_helper'
 
 module Reviewer
-  class ShellTest < MiniTest::Test
+  class ShellTest < Minitest::Test
     def setup
       @shell = Shell.new
     end

test/reviewer/tool/settings_test.rb

@@ -4,7 +4,7 @@
 
 module Reviewer
   class Tool
-    class SettingsTest < MiniTest::Test
+    class SettingsTest < Minitest::Test
       def setup
         @tool = :example
         @config = {