Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete indexedDB data on logout #383

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Conversation

gary-kim
Copy link
Owner

Fixes #380

@jonathanmmm could you check if this fixes your issue?

@gary-kim gary-kim added the bug Something isn't working label Jul 23, 2021
@gary-kim gary-kim added this to the v0.8.1 milestone Jul 23, 2021
@gary-kim gary-kim force-pushed the fix/380/delete-on-logout branch 2 times, most recently from 7812675 to 82dd522 Compare July 23, 2021 19:00
@jonathanmmm
Copy link
Contributor

@gary-kim Should I try it by changing the specific files myself? The build didn't finish so 0.8.1 is not released.

Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim gary-kim force-pushed the fix/380/delete-on-logout branch from 82dd522 to 82c582e Compare July 23, 2021 19:07
@gary-kim
Copy link
Owner Author

gary-kim commented Jul 23, 2021

The continuous integration system doesn't make a new version per PR.

You can try installing it using the README installation instruction: https://github.com/gary-kim/riotchat/blob/master/README.md#installation

@jonathanmmm
Copy link
Contributor

I tried changing the files manually but I can't find the .js files (probably compiled?).
Would be easy for you to just compile it and paste it here as a tar.gz or so?
Otherwise, I try it on another server to compile (want to keep my production server clean).

@jonathanmmm
Copy link
Contributor

jonathanmmm commented Jul 23, 2021

@gary-kim I did the following

git clone https://github.com/gary-kim/riotchat.git
cd riotchat
git checkout fix/380/delete-on-logout
git pull
git submodule update --init --recursive
make

und nach make kommt folgende Fehlermeldung:

(cd 3rdparty/riot-web && rm -rf ../riot && yarn && yarn add @nextcloud/browserslist-config && yarn build && cp config.sample.json webapp/ && cp element.io/develop/config.json webapp/develop.config.json && git describe --exact-match HEAD | cut -c 2- > webapp/version && mv webapp ../riot && yarn remove @nextcloud/browserslist-config) || (cd 3rdparty/riot-web && yarn remove @nextcloud/browserslist-config && exit 1)
00h00m00s 0/0: : ERROR: There are no scenarios; must have at least one.
00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'remove'
make: *** [Makefile:17: 3rdparty/riot] Fehler 1

Fehler 1 means Error 1

Tried to access it anyways, but it just shows a blank page.

I am using nextcloud-fpm docker container, so it is installed unter custom_apps. I stopped the container before installing it and starting the container after.

@jonathanmmm
Copy link
Contributor

Same happens with the master branch, I installed yarn, npm, node-js, make.

@gary-kim
Copy link
Owner Author

@gary-kim
Copy link
Owner Author

Okay, I'll merge this for now.

@gary-kim gary-kim merged commit 86983c0 into master Jul 26, 2021
@gary-kim gary-kim deleted the fix/380/delete-on-logout branch July 26, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Out when Nextcloud logs out
2 participants