config parameter disabling forcing sso iframe

[jonathanmmm]

haven't checked if it works

[jonathanmmm]

would fix #462

[jonathanmmm]

@gary-kim it should build, I only changed one file and it complains about missing package:

[1/2] Removing module @nextcloud/browserslist-config...
error This module isn't specified in a package.json file.
info Visit https://yarnpkg.com/en/docs/cli/remove for documentation about this command.
make: *** [Makefile:18: 3rdparty/riot] Error 1

could you have a look at it?

[jonathanmmm]

Now it passes all checks, have only changed false to true in the comment in line 59.

[gary-kim]

Yeah, my bad. I think the build fixed itself because I updated one of the container images used in the build process.

[gary-kim]

So, to add a new config, you will need to add it here with the default value:

riotchat/lib/AppInfo/Application.php

Line 38 in 5b10eed

public const AvailableSettings = [

then make it available to the frontend where you want to use it by adding another one of these:

riotchat/lib/Controller/AppController.php

Line 60 in 5b10eed

$this->initialStateService->provideInitialState(Application::APP_ID, 'disable_custom_urls',

then add it to the admin settings by putting it here (should be similar to the disable custom URLs setting):

riotchat/src/components/AdminSettings.vue

Lines 57 to 67 in 5b10eed

	<input
	id="disable_custom_urls"
	v-model="disable_custom_urls"
	type="checkbox"
	class="checkbox"
	@change="updateSetting('disable_custom_urls')"
	>
	<label
	ref="disable_custom_urls"
	for="disable_custom_urls"
	>{{ t('riotchat', 'Disable custom URLs') }}</label>

and here

riotchat/src/components/AdminSettings.vue

Line 234 in 5b10eed

"sso_immediate_redirect": loadState('riotchat', 'sso_immediate_redirect') === 'true',

[jonathanmmm]

Have done it

then make it available to the frontend where you want to use it by adding another one of these:

riotchat/lib/Controller/AppController.php

Line 60 in 5b10eed

$this->initialStateService->provideInitialState(Application::APP_ID, 'disable_custom_urls',

I am not sure if I implemented this part correctly.

[jonathanmmm]

Maybe need documentary somewhere, if someone is using custom config.

[jonathanmmm]

Have done it

then make it available to the frontend where you want to use it by adding another one of these:

riotchat/lib/Controller/AppController.php

Line 60 in 5b10eed

$this->initialStateService->provideInitialState(Application::APP_ID, 'disable_custom_urls',

I am not sure if I implemented this part correctly.

@gary-kim did you check if implemented this part correctly?

Also where would be a good place to document this?

[gary-kim]

Okay, tested it myself. It does work though the text of the setting and the effect of the setting seem reversed at the moment.

I think we can just fix that and make the setting name a bit clearer and that should be done!

As far as documentation goes, I think just being in the settings will be good enough for now. If questions start being asked, we can make some system for documentation. For now I'd prefer to have it be self-documenting if possible.

[gary-kim]

Suggested change

	if (loadState('riotchat', 'sso_force_iframe') !== 'false') {
	if (loadState('riotchat', 'sso_force_iframe') === 'false') {

[jonathanmmm]

I think more setting it to !== 'true' would be better, if the value is anything else it will then be treated as false, but your suggestion is easier to read.

[gary-kim]

Alright, tested and it seems to work great! Thank you!