feat: add desktop sub navigation support #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview Environment deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop part of #95
Should be enough to unblock any issues that either requires multiple levels of navigation or child-items without a top level page (we see some cases of this in current project due to content production delays). On mobile we still have a bit of room to go on before we are filled up
Introduces NavItem that essentially have four possible states (when being hovered). When not hovered it gets highlighted as active if itself or any child item matches current path (exactly)
Non-clickable top item, with children
Non-clickable top item, no children (🤔)
Clickable top item, with children
Clickable top item, no children
