Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add combined hamburger and hover navigation #120

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

niccofyren
Copy link
Member

@niccofyren niccofyren commented Dec 3, 2024

Closes: #114

Still a couple of quirks to iron out, but should (🤞) fix issue goals. Logic is

  • Show top navbar items from md and up, gradually showing more items as needed (hide rightmost item when out of space)
  • Show hamburger for all sizes, always including all menu items
  • Switch all navigation items from hover to click/tap/toggle on touch devices
  • ...

A couple of examples

Desktop with room for all top items
Screenshot 2024-12-04 at 00 15 03

... with expanded hamburger
Screenshot 2024-12-04 at 00 15 15

... with hovered nav item
Screenshot 2024-12-04 at 00 15 26

Slightly smaller viewport with nav items hidden
Screenshot 2024-12-04 at 00 15 50

Smallest (mobile) breakpoint with only hamburger menu
Screenshot 2024-12-04 at 00 16 13

... with expanded hamburger
Screenshot 2024-12-04 at 00 16 23

@niccofyren niccofyren marked this pull request as ready for review December 3, 2024 23:21
@niccofyren niccofyren requested a review from a team as a code owner December 3, 2024 23:21
@niccofyren niccofyren requested a review from pr0xity December 3, 2024 23:21
Copy link

github-actions bot commented Dec 3, 2024

Preview Environment deleted

@niccofyren niccofyren merged commit a5e5ce2 into main Dec 4, 2024
6 checks passed
@niccofyren niccofyren deleted the feat/hybrid-mode-navigation branch December 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix navigation issues on small desktop windows
1 participant