Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tg25 logo to header #121

Merged
merged 1 commit into from
Dec 14, 2024
Merged

feat: add tg25 logo to header #121

merged 1 commit into from
Dec 14, 2024

Conversation

niccofyren
Copy link
Member

@niccofyren niccofyren commented Dec 7, 2024

Closes: #117

Do not merge, only switched out of draft state to get review url

In order to make logo details comfortable enough I had to increase header size a bit. Think slimmer header looks a bit nicer, but not end of the world.

Did not change favicon, as I'm not quite sure icon is very TG recognisable. Example
Screenshot 2024-12-07 at 10 47 43

Examples using current logo variants

Ended up using the horisontal logo variant for all cases, since

  • It doesn't require any more height than the square variant (and provides more relevant info/context)
  • It bears way more profile/theme context than standalone symbol
Screenshot 2024-12-07 at 10 39 21 Screenshot 2024-12-07 at 10 40 00 Screenshot 2024-12-07 at 10 40 15

@niccofyren niccofyren marked this pull request as ready for review December 7, 2024 09:50
@niccofyren niccofyren requested a review from a team as a code owner December 7, 2024 09:50
@niccofyren niccofyren requested a review from mfyll December 7, 2024 09:50
Copy link

github-actions bot commented Dec 7, 2024

Preview Environment deleted

@niccofyren niccofyren merged commit 4d5dbfe into main Dec 14, 2024
6 checks passed
@niccofyren niccofyren deleted the feat/tg25-logo branch December 14, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Launch header with TG25 theme logo
1 participant