Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(articles): broken main image #22

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

pr0xity
Copy link
Contributor

@pr0xity pr0xity commented Oct 7, 2024

This makes the main image for the article show again 😄

@pr0xity pr0xity requested a review from a team as a code owner October 7, 2024 19:41
@pr0xity pr0xity requested a review from niccofyren October 7, 2024 19:41
src/pages/news/[slug].astro Outdated Show resolved Hide resolved
api_url: string;
limit?: number;
offset?: number;
tags?: string[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could very well be on my side, but let's double check if prettier is being used (in theory we should see no diffs like this between prs from different contributors)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need set some more config in the projects prettier file 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it might be on my end in this case, if forcing prettier to run it seems to output this format. But that it doesn't trigger automatically does seem to indicate we might need more/better config 😄

@pr0xity pr0xity merged commit 66ed122 into main Oct 7, 2024
1 check passed
@pr0xity pr0xity deleted the fix/broken-article-main-image branch October 7, 2024 19:57
@olemathias
Copy link
Member

@niccofyren
Copy link
Member

@olemathias @pr0xity If you prefer to align in backend instead gathering/tgno-backend#24

@pr0xity
Copy link
Contributor Author

pr0xity commented Oct 7, 2024

@olemathias @pr0xity If you prefer to align in backend instead gathering/tgno-backend#24

I think fixing this in backend makes most sense 👍

Fixed here gathering/tgno-backend#23 @olemathias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants