-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(articles): broken main image #22
Conversation
api_url: string; | ||
limit?: number; | ||
offset?: number; | ||
tags?: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could very well be on my side, but let's double check if prettier is being used (in theory we should see no diffs like this between prs from different contributors)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need set some more config in the projects prettier file 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it might be on my end in this case, if forcing prettier to run it seems to output this format. But that it doesn't trigger automatically does seem to indicate we might need more/better config 😄
@olemathias @pr0xity If you prefer to align in backend instead gathering/tgno-backend#24 |
I think fixing this in backend makes most sense 👍 Fixed here gathering/tgno-backend#23 @olemathias |
This makes the main image for the article show again 😄