Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add): Add simple PR preview environments #76

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat(add): Add simple PR preview environments #76

merged 1 commit into from
Oct 21, 2024

Conversation

olemathias
Copy link
Member

@olemathias olemathias commented Oct 20, 2024

Simple preview environments on all PRs. Can be used to test and showcase new features before merging to production.
The environment will be deleted after the PR is merged.

Using dev.tg.no as backend for now. If we do the same for backend we need to find a way to connect the two environments.
Had to write a little python since the argocd cli do not support setting Kustomize patches on applications.

Part of #71

@olemathias olemathias requested a review from a team as a code owner October 20, 2024 23:54
@olemathias olemathias requested a review from niccofyren October 20, 2024 23:54
@olemathias olemathias force-pushed the preview branch 5 times, most recently from 40ede13 to 144d190 Compare October 21, 2024 00:24
Copy link

github-actions bot commented Oct 21, 2024

Preview Environment deleted

@mfyll
Copy link
Member

mfyll commented Oct 21, 2024

Cool! Do we need to make sure theese Preview-envs dont end up on Google? For example with Robots.txt: https://tgno-pr76.preview.tg.no/robots.txt

@olemathias
Copy link
Member Author

Cool! Do we need to make sure theese Preview-envs dont end up on Google? For example with Robots.txt: https://tgno-pr76.preview.tg.no/robots.txt

The same will apply to dev.tg.no today

@olemathias olemathias force-pushed the preview branch 7 times, most recently from 48bf0a5 to 00e959d Compare October 21, 2024 14:30
@olemathias olemathias marked this pull request as draft October 21, 2024 14:32
@olemathias olemathias marked this pull request as ready for review October 21, 2024 14:49
@olemathias olemathias changed the title WIP - feat(add): init pr preview feat(add): Add simple PR preview enviroments Oct 21, 2024
@olemathias
Copy link
Member Author

olemathias commented Oct 21, 2024

Cool! Do we need to make sure theese Preview-envs dont end up on Google? For example with Robots.txt: https://tgno-pr76.preview.tg.no/robots.txt

Changed, now only production should be indexed (using robots.txt)

@olemathias olemathias requested review from mfyll and pr0xity October 21, 2024 14:56
src/pages/index.astro Outdated Show resolved Hide resolved
@olemathias olemathias changed the title feat(add): Add simple PR preview enviroments feat(add): Add simple PR preview environments Oct 21, 2024
Copy link
Member

@mfyll mfyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job, very nice! 😎

@olemathias olemathias merged commit 1d51fd9 into main Oct 21, 2024
4 checks passed
@olemathias olemathias deleted the preview branch October 21, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants