-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(add): Add simple PR preview environments #76
Conversation
40ede13
to
144d190
Compare
Preview Environment deleted |
Cool! Do we need to make sure theese Preview-envs dont end up on Google? For example with Robots.txt: https://tgno-pr76.preview.tg.no/robots.txt |
The same will apply to dev.tg.no today |
48bf0a5
to
00e959d
Compare
Changed, now only production should be indexed (using robots.txt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job, very nice! 😎
Simple preview environments on all PRs. Can be used to test and showcase new features before merging to production.
The environment will be deleted after the PR is merged.
Using dev.tg.no as backend for now. If we do the same for backend we need to find a way to connect the two environments.
Had to write a little python since the argocd cli do not support setting Kustomize patches on applications.
Part of #71