chore(repo): update non-major dependency versions (#468)

* chore(repo): update non-major dependency versions * chore: update deps and get broken lint rules working --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Moon <moonmeister@users.noreply.github.com>
gatsby-uc · Oct 11, 2024 · 67b7397 · 67b7397
1 parent e7f1d20
commit 67b7397
Show file tree

Hide file tree

Showing 11 changed files with 5,833 additions and 11,140 deletions.
diff --git a/.changeset/lovely-wombats-relax.md b/.changeset/lovely-wombats-relax.md
@@ -0,0 +1,8 @@
+---
+"gatsby-plugin-pinterest": patch
+"gatsby-source-packagist": patch
+"gatsby-plugin-fastify": patch
+"gatsby-source-strapi": patch
+---
+
+Refactor code for updated linting rules
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -0,0 +1,3 @@
+{
+  "eslint.useFlatConfig": true
+}
diff --git a/eslint.config.js b/eslint.config.js
@@ -76,6 +76,16 @@ module.exports = [
     },
     rules: {
       ...typescript.configs.recommended.rules,
+      "unicorn/import-style": [
+        "error",
+        {
+          styles: {
+            "node:path": {
+              named: true,
+            },
+          },
+        },
+      ],
     },
   },
   {

diff --git a/package.json b/package.json
@@ -26,25 +26,25 @@
     "@babel/eslint-parser": "^7.25.7",
     "@babel/preset-react": "^7.25.7",
     "@changesets/changelog-github": "^0.5.0",
-    "@changesets/cli": "^2.27.1",
-    "@hkdobrev/run-if-changed": "^0.3.1",
-    "@tsconfig/node20": "^20.1.2",
-    "@typescript-eslint/eslint-plugin": "^6.16.0",
-    "@typescript-eslint/parser": "^6.16.0",
+    "@changesets/cli": "^2.27.9",
+    "@hkdobrev/run-if-changed": "^0.6.1",
+    "@tsconfig/node20": "^20.1.4",
+    "@typescript-eslint/eslint-plugin": "^8.8.1",
+    "@typescript-eslint/parser": "^8.8.1",
     "all-contributors-cli": "^6.26.1",
     "chalk": "^5.3.0",
-    "eslint": "^8.56.0",
+    "eslint": "^9.12.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-react": "^7.33.2",
-    "eslint-plugin-unicorn": "^50.0.1",
+    "eslint-plugin-react": "^7.37.1",
+    "eslint-plugin-unicorn": "^56.0.0",
     "fs-extra": "^11.2.0",
     "husky": "^8.0.3",
-    "lint-staged": "^15.2.0",
-    "prettier": "^3.1.1",
-    "renovate": "^37.115.0",
-    "typescript": "^5.3.3"
+    "lint-staged": "^15.2.10",
+    "prettier": "^3.3.3",
+    "renovate": "^37.440.7",
+    "typescript": "^5.6.3"
   },
-  "packageManager": "yarn@4.0.2+sha256.825003a0f561ad09a3b1ac4a3b3ea6207af2796d54f62a9420520915721f5186",
+  "packageManager": "yarn@4.5.0+sha512.837566d24eec14ec0f5f1411adb544e892b3454255e61fdef8fd05f3429480102806bac7446bc9daff3896b01ae4b62d00096c7e989f1596f2af10b927532f39",
   "lint-staged": {
     "**/*.{mjs,js,ts,md,json,yml,json5}": "prettier --write",
     "packages/**/*.{js,ts}": "eslint --fix"

diff --git a/packages/gatsby-plugin-fastify/src/cli.ts b/packages/gatsby-plugin-fastify/src/cli.ts
@@ -6,6 +6,7 @@ import { hideBin } from "yargs/helpers";
 import { gatsbyServer } from "./serve";
 import open from "open";
 
+// eslint-disable-next-line @typescript-eslint/no-unused-expressions
 yargs(hideBin(process.argv))
   .env("GATSBY_SERVER_")
   .command(

diff --git a/packages/gatsby-plugin-fastify/src/plugins/redirects.ts b/packages/gatsby-plugin-fastify/src/plugins/redirects.ts
@@ -43,7 +43,9 @@ export const handleRedirects: FastifyPluginAsync<{
     }
 
     if (!alreadyRegisterd.has(cleanFromPath)) {
-      isCleanedPath && alreadyRegisterd.add(cleanFromPath);
+      if (isCleanedPath) {
+        alreadyRegisterd.add(cleanFromPath);
+      }
 
       fastify.all<{
         Params: {

diff --git a/packages/gatsby-plugin-fastify/src/utils/log.ts b/packages/gatsby-plugin-fastify/src/utils/log.ts
@@ -4,8 +4,11 @@ export function countPaths(paths: ServerSideRoute[]) {
   const results = { dsgCount: 0, ssrCount: 0 };
 
   for (const path of paths) {
-    path.mode === "SSR" && results.ssrCount++;
-    path.mode === "DSG" && results.dsgCount++;
+    if (path.mode === "SSR") {
+      results.ssrCount += 1;
+    } else if (path.mode === "DSG") {
+      results.dsgCount += 1;
+    }
   }
 
   return results;

diff --git a/packages/gatsby-plugin-pinterest/src/gatsby-browser.js b/packages/gatsby-plugin-pinterest/src/gatsby-browser.js
@@ -38,8 +38,12 @@ export const onRouteUpdate = (arguments_, pluginOptions = {}) => {
       injectedPinterestScript = true;
     }
 
-    if (!hover && typeof PinUtils !== `undefined` && typeof window.PinUtils.build === `function`) {
-      window.PinUtils.build();
+    if (
+      !hover &&
+      typeof PinUtils !== `undefined` &&
+      typeof globalThis.PinUtils.build === `function`
+    ) {
+      globalThis.PinUtils.build();
     }
   }
 };
diff --git a/packages/gatsby-source-packagist/src/gatsby-node.js b/packages/gatsby-source-packagist/src/gatsby-node.js
@@ -40,7 +40,7 @@ export async function createResolvers(
   { actions, createResolvers, createNodeId, reporter, store, cache },
   { githubApi },
 ) {
-  global.reporter = reporter;
+  globalThis.reporter = reporter;
   const { createNode } = actions;
 
   const README_DOMAINS = {};

diff --git a/packages/gatsby-source-strapi/src/helpers.js b/packages/gatsby-source-strapi/src/helpers.js
@@ -71,7 +71,7 @@ const buildNodesToRemoveMap = (existingNodesMap, endpoints, data) => {
     }
 
     accumulator[name] = value.filter((index) => {
-      return currentNodes.findIndex((k) => k.strapi_id === index.strapi_id) === -1;
+      return !currentNodes.some((k) => k.strapi_id === index.strapi_id);
     });
 
     return accumulator;
@@ -93,7 +93,7 @@ const getEndpoints = ({ collectionTypes, singleTypes, version = 4 }, schemas) =>
     .filter(
       ({ schema, uid }) =>
         !uid.startsWith("admin::") &&
-        types.findIndex(({ singularName }) => singularName === schema.singularName) !== -1,
+        types.some(({ singularName }) => singularName === schema.singularName),
     )
     .map(({ schema: { kind, singularName, pluralName }, uid, plugin }) => {
       const options = types.find((config) => config.singularName === singularName);