Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -release repository check in release.py #1019

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Sep 27, 2023

Fix the fail in the check for github repository, that now displays the error:

Error running command (git ls-remote -q --exit-code https://foo:foo@github.com/gazebo-release/gz-cmake-release).
stdout: 
stderr: remote: Support for password authentication was removed on August 13, 2021.
remote: Please see https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls for information on currently recommended modes of authentication.
fatal: Authentication failed for 'https://github.com/gazebo-release/gz-cmake-release/'

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero changed the title jrivero/fix github check Fix -release repository check in release.py Sep 27, 2023
Copy link
Contributor

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@j-rivero j-rivero merged commit b7e7475 into master Oct 2, 2023
1 check passed
@j-rivero j-rivero deleted the jrivero/fix_github_check branch October 2, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants