Fixes for OSRFSourceCreation and tests related #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Do not use TARBALL_NAME anymore and use S3_FILES_TO_UPLOAD instead. Improve the testing script by listing all possible files passed. Fix the use of relative path instead the absolute one. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
20 tasks
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
The ~ symbol used in prereleases is not supported by git tags. Needs to convert it to a -.
j-rivero
force-pushed
the
jrivero/part1_dsl_gz_source_jobs
branch
from
43d08ca
to
42c47ed
Compare
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
force-pushed
the
jrivero/part1_dsl_gz_source_jobs
branch
from
42c47ed
to
0215e2b
Compare
|
Tested: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #989 and #1008, some fixes and improve of the testing. Each commit is self-contained: