Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gz- projects on Homebrew CI #778

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Use gz- projects on Homebrew CI #778

merged 4 commits into from
Aug 3, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 3, 2022

Test build using this PR together with the 2 above: Build Status


Ah had to rebuild the DSL with this branch: Build Status

Build after rebuilding the DSL: Build Status

Annnd I built the wrong DSL before, I think this should do it: Build Status

New new build: Build Status


After 465385a

Another DSL Build Status

New new new build: Build Status


After ef6148b

DSLs

  • Build Status
  • Build Status

Build: Build Status

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from j-rivero as a code owner August 3, 2022 18:53
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

Success!

+ brew install gz-cmake4 --only-dependencies
...
==> Installing ignition-cmake3 from osrf/simulation
==> Installing dependencies for osrf/simulation/ignition-cmake3: pkg-config
==> Installing osrf/simulation/ignition-cmake3 dependency: pkg-config
==> Pouring pkg-config--0.29.2_3.big_sur.bottle.tar.gz

@@ -13,10 +13,10 @@ export HOMEBREW_MAKE_JOBS=${MAKE_JOBS}
PROJECT=$1 # project will have the major version included (ex gazebo2)
PROJECT_ARGS=${2}

# In ignition projects, the name of the repo and the formula does not match
# TODO(chapulina) Use gz path instead of legacy ign
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason not to use the new gz- and use the legacy instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my first approach, and the test run showed that more things would need to be changed, so I though of keeping this PR to the strictly necessary for now.

@j-rivero
Copy link
Contributor

j-rivero commented Aug 3, 2022

The CI includes the testing of bottles so we are going to need to modify the bottle name var in DSL when new gz- bottles are created. We can create a different PR for this if you prefer to keep this one small and go fast.

Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about not using the legacy mechanism but looks good in either way.

@chapulina
Copy link
Contributor Author

The CI includes the testing of bottles so we are going to need to modify the bottle name var in DSL when new gz- bottles are created.

I hadn't realized that. So is merging this PR going to break anything? I thought I was only affecting these CI jobs:

  • ignition_${ign_sw}-ci-pr_any-homebrew-amd64
  • ignition_${ign_sw}-ci-${branch}-homebrew-amd64
  • ignition_${ign_collection_name}-ci-main-homebrew-amd64

@j-rivero
Copy link
Contributor

j-rivero commented Aug 3, 2022

I hadn't realized that. So is merging this PR going to break anything? I thought I was only affecting these CI jobs:

It is not going to break anything, I was reviewing the status of other things affected by migration as part of Homebrew CI.

@chapulina chapulina merged commit 180794e into master Aug 3, 2022
@chapulina chapulina deleted the chapulina/gz/homebrew branch August 3, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants