-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gz- projects on Homebrew CI #778
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Success!
|
@@ -13,10 +13,10 @@ export HOMEBREW_MAKE_JOBS=${MAKE_JOBS} | |||
PROJECT=$1 # project will have the major version included (ex gazebo2) | |||
PROJECT_ARGS=${2} | |||
|
|||
# In ignition projects, the name of the repo and the formula does not match | |||
# TODO(chapulina) Use gz path instead of legacy ign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason not to use the new gz- and use the legacy instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my first approach, and the test run showed that more things would need to be changed, so I though of keeping this PR to the strictly necessary for now.
The CI includes the testing of bottles so we are going to need to modify the bottle name var in DSL when new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment about not using the legacy mechanism but looks good in either way.
I hadn't realized that. So is merging this PR going to break anything? I thought I was only affecting these CI jobs:
|
It is not going to break anything, I was reviewing the status of other things affected by migration as part of Homebrew CI. |
Test build using this PR together with the 2 above:
Ah had to rebuild the DSL with this branch:
Build after rebuilding the DSL:
Annnd I built the wrong DSL before, I think this should do it:
New new build:
After 465385a
Another DSL
New new new build:
After ef6148b
DSLs
Build: