Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows binary #327

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Update windows binary #327

merged 4 commits into from
Dec 21, 2022

Conversation

Bi0T1N
Copy link
Contributor

@Bi0T1N Bi0T1N commented Dec 17, 2022

🦟 Bug fix

Summary

Fixes use of old ignition package name, all packages are available for Windows (sdformat as well) and rename of Conda environment.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Bi0T1N
Ticket for missing recipes is closed
c974110 
Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
@Bi0T1N
Fix naming of environment and use new package names
6cffd51 
- rename environment to use gz prefix
- all libraries are available for Windows with the libgz prefix
- fix old ignition package prefix

Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
@Bi0T1N Bi0T1N requested a review from mabelzhang as a code owner December 17, 2022 15:34
@github-actions github-actions bot added the 🌱 garden Gazebo Garden label Dec 17, 2022
@traversaro
Copy link
Contributor

If you want to also install the Python bindings in the package that have them, you can install the gz- packages instead of the libgz- packages (this is something new in garden, see conda-forge/libignition-cmake0-feedstock#26 (comment)).

@Bi0T1N
Add new package names introduced for Garden
814776d 
Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
@Bi0T1N
Copy link
Contributor Author

Bi0T1N commented Dec 18, 2022

@traversaro Thanks for the hint. I've added your naming scheme with my latest commit.

@azeey
Copy link
Contributor

azeey commented Dec 19, 2022

@traversaro does this mean Gazebo works on windows without any issues?

@azeey azeey self-requested a review December 19, 2022 19:44
@traversaro
Copy link
Contributor

traversaro commented Dec 20, 2022 •
edited
Loading

@traversaro does this mean Gazebo works on windows without any issues?

No, sorry if I gave that impression. The major Windows blocker are relocability issues (see gazebosim/gz-sim#168 (comment)), I have some patches for that in gazebosim/gz-sim#626 (comment) . I plan to clean them up and submit them upstream. As these patches change the public API/ABI, I am not confident backporting them in conda-forge as if then the review change them, it would be tricky to mantain the API/ABI symbols introduced by the outdated patches.

traversaro
traversaro reviewed Dec 20, 2022
View reviewed changes
Copy link
Contributor

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

garden/install_windows.md Outdated Show resolved Hide resolved
@azeey
Copy link
Contributor

azeey commented Dec 21, 2022

Okay, thanks for clarifying.

@Bi0T1N
Fix missing placeholder for version number
f483294 
Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
@azeey azeey merged commit 7fac0de into gazebosim:master Dec 21, 2022
@j-rivero j-rivero mentioned this pull request Mar 7, 2023
Merged
@Bi0T1N Bi0T1N deleted the update_windows_binary branch April 27, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro left review comments

@azeey azeey azeey approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

Assignees
No one assigned
Labels
🌱 garden Gazebo Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bi0T1N @traversaro @azeey