Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for work without pkg-config for FindUUID #64

Closed
osrf-migration opened this issue Sep 9, 2019 · 5 comments
Closed

Support for work without pkg-config for FindUUID #64

osrf-migration opened this issue Sep 9, 2019 · 5 comments
Labels
bug Something isn't working major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Silvio Traversaro (Bitbucket: traversaro).


Summary

Add code to permit to FindUUID to work even without pkg-config installed in the system.

Motivation

At the moment the FindUUID CMake scripts assume that pkg-config is installed in the system to work. This is a reasonable assumption, as FindUUID is supposed to work only on *nix systems. However, unfortunately the vcpkg continuous integration on Linux does not have/require pkg-config installed, and so the stock FindUUID fails on that machine, see microsoft/vcpkg#8044 (comment) . For this reason, it may be convient to support this case.

Describe alternatives you've considered

Leave the patch just in the vcpkg port: as in almost all other cases pkg-config will be installed, it make sense that the burden of maintenance of this case remains on the vcpkg side.

Additional context

The patch is already available in vcpkg at https://github.com/microsoft/vcpkg/pull/8044/files#diff-d3ef7f499fd629bfd6d5029bf3847dea , but I am not sure if it is of general interest, so I will open a PR only if there is interest.

@osrf-migration
Copy link
Author

Original comment by Silvio Traversaro (Bitbucket: traversaro).


  • Edited issue description

2 similar comments
@osrf-migration
Copy link
Author

Original comment by Silvio Traversaro (Bitbucket: traversaro).


  • Edited issue description

@osrf-migration
Copy link
Author

Original comment by Silvio Traversaro (Bitbucket: traversaro).


  • Edited issue description

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 15, 2020
@traversaro
Copy link
Contributor

Clearly when packaging ignition-cmake2 for vcpkg ( microsoft/vcpkg#10014 ) I had completely forgot this patch, and now the dependent ports are not finding uuid .

@traversaro
Copy link
Contributor

This was fixed in #95, so we can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

3 participants