Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for finding several dependencies without pkg-config #95

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

traversaro
Copy link
Contributor

In particular, add a dedicated ign_manual_search CMake macro, and then use it in FindUUID (fix #64) and in the find scripts for FFMPEG libraries.

@scpeters
Copy link
Member

we are also calling find_path and find_library in several other find modules:

$ grep -l find_library $(grep -rlI find_path cmake/Find*) | sort
cmake/FindDL.cmake
cmake/FindFreeImage.cmake
cmake/FindGTS.cmake
cmake/FindIgnOGRE2.cmake
cmake/FindJSONCPP.cmake
cmake/FindODE.cmake
cmake/FindOptiX.cmake
cmake/FindSQLite3.cmake
cmake/FindTINYXML2.cmake
cmake/FindYAML.cmake
cmake/FindZIP.cmake

I suspect that we could use ign_manual_search in these find modules, though it's not needed for this PR.

@traversaro
Copy link
Contributor Author

we are also calling find_path and find_library in several other find modules:

$ grep -l find_library $(grep -rlI find_path cmake/Find*) | sort
cmake/FindDL.cmake
cmake/FindFreeImage.cmake
cmake/FindGTS.cmake
cmake/FindIgnOGRE2.cmake
cmake/FindJSONCPP.cmake
cmake/FindODE.cmake
cmake/FindOptiX.cmake
cmake/FindSQLite3.cmake
cmake/FindTINYXML2.cmake
cmake/FindYAML.cmake
cmake/FindZIP.cmake

I suspect that we could use ign_manual_search in these find modules, though it's not needed for this PR.

Yes, a few of those would probably need to expose some other parameters in the ign_manual_search API, but for the moment I preferred to have the minimal changes necessary for microsoft/vcpkg#11273 (comment) .

@mjcarroll mjcarroll self-assigned this May 19, 2020
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@traversaro Can you bring this up to date so we can land it?

This macro is useful for manually find a C/C++ library,
and it is typically used as a fallback if a library is not found with pkg-config.

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@traversaro
Copy link
Contributor Author

@traversaro Can you bring this up to date so we can land it?

Done!

@chapulina chapulina merged commit b3116af into gazebosim:ign-cmake2 Jun 12, 2020
@traversaro traversaro deleted the find_without_pkg_config branch June 12, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants