FindUUID: Do not wrap LIBRARY_NAMES argument with quotes #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
mxgrey,
j-rivero and
scpeters
as code owners
github-actions
bot
added
🏯 fortress
5 tasks
Signed-off-by: Silvio <silvio@traversaro.it>
scpeters
approved these changes
Oct 21, 2022
|
thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes conda-forge/libignition-cmake0-feedstock#32 .
Summary
Apparently
FindUUIDdoes not find uuid if pkg-config is not installed in the system, even if #95 should have added support for this. This was due to a bug in #95 that is fixed in this PR: multiple arguments to a parameter should not be passed inside quotes, otherwise there are considered as a single parameter.For consistency, I also removed the quotes from the other arguments to the same function call.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.