Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge: 5 -> main #537

Merged
merged 12 commits into from
Sep 26, 2023
Merged

Merge: 5 -> main #537

merged 12 commits into from
Sep 26, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 26, 2023

➡️ Forward port

Port gz-common5 to main

Branch comparison: main...gz-common5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

mjcarroll and others added 12 commits July 12, 2023 15:47
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from marcoag as a code owner September 26, 2023 20:34
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #537 (57bc634) into main (962800d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 57bc634 differs from pull request most recent head ca982d2. Consider uploading reports for the commit ca982d2 to get more accurate results

@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   83.21%   83.21%           
=======================================
  Files          82       82           
  Lines        9880     9880           
=======================================
  Hits         8222     8222           
  Misses       1658     1658           
Files Coverage Δ
graphics/src/AssimpLoader.cc 89.37% <0.00%> (ø)

@iche033
Copy link
Contributor Author

iche033 commented Sep 26, 2023

homebrew warning is addressed in #529

@iche033 iche033 merged commit 12872b3 into main Sep 26, 2023
10 of 11 checks passed
@iche033 iche033 deleted the merge_5_main_20230926 branch September 26, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants