Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate env() with two parameters #653

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Deprecate env() with two parameters #653

merged 1 commit into from
Dec 2, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Dec 2, 2024

As part of the Ionic tick-tock process, we're updating this function in favor of the version with three arguments. We also make the three version function works with two arguments only.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero requested a review from marcoag as a code owner December 2, 2024 17:25
@caguero caguero merged commit 0c05864 into main Dec 2, 2024
11 checks passed
@caguero caguero deleted the caguero/deprecate_env branch December 2, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants