Use gz::utils::ImplPtr as much as possible #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
==========================================
- Coverage 70.06% 68.07% -2.00%
==========================================
Files 39 38 -1
Lines 5359 5369 +10
==========================================
- Hits 3755 3655 -100
- Misses 1604 1714 +110
|
mjcarroll
force-pushed
the
mjcarroll/implptr
branch
from
6a617e0 to
2749022
Compare
mjcarroll
force-pushed
the
mjcarroll/tidy_namespace
branch
from
3e5c68e to
3290544
Compare
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
mjcarroll
force-pushed
the
mjcarroll/implptr
branch
from
2749022 to
b84c93f
Compare
mjcarroll
changed the base branch from
mjcarroll/tidy_namespace
to
ports/8_to_main
mjcarroll
force-pushed
the
mjcarroll/implptr
branch
from
b84c93f to
20bf135
Compare
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
mjcarroll
force-pushed
the
mjcarroll/implptr
branch
from
20bf135 to
ed63b7b
Compare
|
Should be fixed by gazebosim/gz-common#553 |
|
@osrf-jenkins retest this please |
|
@ahcorde I think we are good here now |
ahcorde
approved these changes
Nov 10, 2023
jrutgeer
added a commit
to jrutgeer/gz-gui_camera_add_duration
that referenced
this pull request
Nov 29, 2023
Signed-off-by: Johan Rutgeerts <johan.rutgeerts@lancewood.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the rest of our
std::unique_ptrimplementations over togz::utils::ImplPtr.