Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies to targets #644

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Conversation

udaya2899
Copy link
Contributor

@udaya2899 udaya2899 commented Nov 14, 2024

🦟 Bug fix

Summary

Fixes missing Bazel dependencies to make gz-math work with bzlmod

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Udaya Prakash <udayaprakash2899@gmail.com>
Signed-off-by: Udaya Prakash <udayaprakash2899@gmail.com>
Signed-off-by: Udaya Prakash <udayaprakash2899@gmail.com>
Signed-off-by: Udaya Prakash <udayaprakash2899@gmail.com>
@azeey
Copy link
Contributor

azeey commented Nov 14, 2024

@mjcarroll / @shameekganguly is there a reason CI is not catching missing dependencies?

@udaya2899
Copy link
Contributor Author

My hunch is that it doesn't actually evaluate those headers used in the .hh files. Why this is happening is out of my reach.

@mjcarroll
Copy link
Contributor

My hunch is that it doesn't actually evaluate those headers used in the .hh files. Why this is happening is out of my reach.

The only thing that would probably exercise this is the unit tests, which probably either also include the same headers or get the transitively somehow.

BUILD.bazel Show resolved Hide resolved
udaya2899 and others added 2 commits November 14, 2024 17:05
Signed-off-by: udayaprakash <udayaprakash@google.com>
@mjcarroll mjcarroll merged commit 44e3bba into gazebosim:gz-math8 Nov 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants