Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bionic from future releases (Garden+) #70

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

chapulina
Copy link
Contributor

Summary

There are no plans to include ign-plugin2 on Garden, but whenever it's officially released, it won't have Bionic support.

Test it

No Bionic builds should be triggered.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added documentation Improvements or additions to documentation tests Broken or missing tests / testing infra labels Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #70 (5b0df75) into main (7c81bcb) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Current head 5b0df75 differs from pull request most recent head a013ad5. Consider uploading reports for the commit a013ad5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   99.83%   99.67%   -0.17%     
==========================================
  Files          16       17       +1     
  Lines         615      616       +1     
==========================================
  Hits          614      614              
- Misses          1        2       +1     
Impacted Files Coverage Δ
core/include/ignition/plugin/detail/Factory.hh 94.44% <0.00%> (-5.56%) ⬇️
core/include/ignition/plugin/Factory.hh 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c81bcb...a013ad5. Read the comment docs.

@chapulina
Copy link
Contributor Author

chapulina commented Mar 11, 2022

I cancelled the Windows build because the buildfarm is swamped and that shouldn't be affected by this PR.

I believe this is good to go!

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 9567027 into main Mar 12, 2022
@chapulina chapulina deleted the chapulina/main/rm/bionic branch March 12, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants