Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running rendering tests if GZ_ENABLE_RELOCATABLE_INSTALL is ON #1073

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 3, 2024

🦟 Bug fix

If GZ_ENABLE_RELOCATABLE_INSTALL is ON, for all tests the environment variable GZ_RENDERING_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} need to be defined, to make sure that even if the shared library in the build directory is used instead of the install prefix, the correctly installed engine plugins are loaded. As part of #804 I modified some tests to set GZ_RENDERING_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}, but I forgot to do this modification in gz_configure_rendering_test, that is actually how most tests in gz-rendering are added.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
@traversaro traversaro requested a review from iche033 as a code owner October 3, 2024 14:49
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Oct 3, 2024
@traversaro traversaro changed the title Fix running rendering tests in GZ_ENABLE_RELOCATABLE_INSTALL is ON Fix running rendering tests if GZ_ENABLE_RELOCATABLE_INSTALL is ON Oct 3, 2024
@iche033 iche033 merged commit 589f6f6 into gazebosim:gz-rendering9 Oct 9, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants