Port Windows fix for unregistering OgreGLWindows class in ogre 2.2 #1092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Unregister window class on Windows to allow repeated loading / unloading of ogre 2.2 (used by ign-rendering6) in the same process, i.e. our unit and integration tests. A similar patch (OGRECave/ogre-next#327) was already submitted by @mjcarroll to ogre-next for version 2.3 (used by gz-rendering7 onwards). Adding the change here for ign-rendering6 so we can run ogre2 tests on our new Windows conda CI.
Note that the
gz_rendering-pr-win
jenkins job in the checks below still uses the old vcpkg based builds so we'll still get many test failures.Here are the new conda test builds:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.