Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Windows fix for unregistering OgreGLWindows class in ogre 2.2 #1092

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 17, 2024

🦟 Bug fix

Summary

Unregister window class on Windows to allow repeated loading / unloading of ogre 2.2 (used by ign-rendering6) in the same process, i.e. our unit and integration tests. A similar patch (OGRECave/ogre-next#327) was already submitted by @mjcarroll to ogre-next for version 2.3 (used by gz-rendering7 onwards). Adding the change here for ign-rendering6 so we can run ogre2 tests on our new Windows conda CI.

Note that the gz_rendering-pr-win jenkins job in the checks below still uses the old vcpkg based builds so we'll still get many test failures.

Here are the new conda test builds:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Dec 17, 2024
@iche033 iche033 requested a review from mjcarroll December 17, 2024 01:01
@iche033 iche033 merged commit d10d19e into ign-rendering6 Dec 17, 2024
10 of 11 checks passed
@iche033 iche033 deleted the unregister_class_ogre2_win branch December 17, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants