Adds bindings for the Actor convenience class #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2041 +/- ##
==========================================
+ Coverage 64.48% 65.39% +0.91%
==========================================
Files 341 318 -23
Lines 27143 30036 +2893
==========================================
+ Hits 17502 19642 +2140
- Misses 9641 10394 +753
|
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Voldivh
force-pushed
the
voldivh/python_bindings_actor
branch
from
53787a7
to
7d050c4
Compare
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Voldivh
force-pushed
the
voldivh/python_bindings_actor
branch
from
da0ad7f
to
a55ee73
Compare
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Voldivh
force-pushed
the
voldivh/python_bindings_actor
branch
from
a55ee73
to
f01c1c3
Compare
Signed-off-by: Eloy Briceno <51831786+Voldivh@users.noreply.github.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Eloy Briceno <51831786+Voldivh@users.noreply.github.com>
ahcorde
requested changes
Aug 17, 2023
Signed-off-by: Eloy Briceno <51831786+Voldivh@users.noreply.github.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
azeey
reviewed
Aug 21, 2023
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
azeey
approved these changes
Aug 21, 2023
ahcorde
approved these changes
Aug 21, 2023
python/src/gz/sim/Actor.cc
Outdated
| #include "Actor.hh" | ||
|
|
||
| namespace py = pybind11; | ||
| using std::chrono::milliseconds; |
There was a problem hiding this comment.
is this used here ? remove ?
There was a problem hiding this comment.
Thanks, I forgot to delete that. Done
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This PR adds bindings for the
Actorconvenience class.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.