Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonic: Address some todos #2054

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Harmonic: Address some todos #2054

merged 3 commits into from
Aug 16, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 27, 2023

🎉 New feature

Summary

Harmonic: Address some todos

Required gazebosim/gz-msgs#365

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Jul 27, 2023
@ahcorde ahcorde requested a review from mjcarroll as a code owner July 27, 2023 09:02
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 27, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@mjcarroll
Copy link
Contributor

@ahcorde Is this blocked on another PR/branch? Builds are failing.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 14, 2023

@mjcarroll I updated the gz-msgs PR and I create a new one in gz-sensor to resolve this comment gazebosim/gz-msgs#365 (comment)

@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 16, 2023

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2054 (bb7b1ce) into main (f18626e) will decrease coverage by 0.03%.
The diff coverage is 11.11%.

❗ Current head bb7b1ce differs from pull request most recent head 4b1a89b. Consider uploading reports for the commit 4b1a89b to get more accurate results

@@            Coverage Diff             @@
##             main    #2054      +/-   ##
==========================================
- Coverage   65.50%   65.47%   -0.03%     
==========================================
  Files         314      314              
  Lines       29796    29814      +18     
==========================================
+ Hits        19517    19520       +3     
- Misses      10279    10294      +15     
Files Changed Coverage Δ
src/systems/air_speed/AirSpeed.cc 76.34% <ø> (ø)
src/Conversions.cc 83.23% <11.11%> (-1.24%) ⬇️

... and 1 file with indirect coverage changes

@ahcorde ahcorde merged commit 5e40cb8 into main Aug 16, 2023
4 of 6 checks passed
@ahcorde ahcorde deleted the ahcorde/harmonic/todos branch August 16, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants