-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonic: Address some todos #2054
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde Is this blocked on another PR/branch? Builds are failing. |
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@mjcarroll I updated the |
@osrf-jenkins run tests please! |
Codecov Report
@@ Coverage Diff @@
## main #2054 +/- ##
==========================================
- Coverage 65.50% 65.47% -0.03%
==========================================
Files 314 314
Lines 29796 29814 +18
==========================================
+ Hits 19517 19520 +3
- Misses 10279 10294 +15
|
🎉 New feature
Summary
Harmonic: Address some todos
Required gazebosim/gz-msgs#365
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.