Fix making breadcrumb static if it's a nested model #2593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes gazebosim/gazebo_test_cases#1593
Breadcrumbs are made static some time after being deployed. This is done by attaching a fixed joint between its canonical link and a dummy static model. However, the logic for finding the canonical link did not work if the breadcrumb is a nested model. This PR fixes finding the canonical link in a nested breadcrumb model so that it can be made static.
To test
launch breadcrumbs.sdf world
Deploy B2
Wait a few seconds and make sure no error msgs such as
[error] Failed to make breadcrumb 'B2_0' static.
is printed.The deployed breadcrumb model should be static.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.