Add tutorial + example SDF for shadow texture size #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Athena Z <athenaz@google.com>
Signed-off-by: Athena Z <athenaz@google.com>
iche033
reviewed
Sep 6, 2024
| <engine>ogre2</engine> | ||
| <camera_pose>-10 0 7 0 0.5 0</camera_pose> | ||
| <shadows> | ||
| <texture_size light_type="directional">16384</texture_size> |
There was a problem hiding this comment.
set this to 8192 as I see that's what the tutorial tells the user to do?
tutorials/shadow_texture_size.md
Outdated
|
|
||
| ### Example usage for the GUI | ||
|
|
||
| Let's change the shadow texture size for directional light with the SDF file below. (The finished SDF file can be viewed [here](https://github.com/gazebosim/gz-sim/blob/main/examples/worlds/shadow_texture_size.sdf).) |
There was a problem hiding this comment.
can you mention that we currently only support changing shadow texture size for directional lights?
There was a problem hiding this comment.
Yup = done here b48725b
There was a problem hiding this comment.
oh can you also change the link to point to gz-sim9 branch? i.e. https://github.com/gazebosim/gz-sim/tree/gz-sim9/examples/worlds/shadow_texture_size.sdf
Co-authored-by: Ian Chen <ichen@openrobotics.org> Signed-off-by: Athena Z. <athenaz@google.com>
Signed-off-by: Athena Z. <athenaz@google.com>
Signed-off-by: Athena Z. <athenaz@google.com>
Signed-off-by: Athena Z. <athenaz@google.com>
iche033
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Add tutorial + example SDF. Related to gazebosim/gz-rendering#1034
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.