Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport SystemConfigurePriority to harmonic #2661

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Backport part of #2500

Summary

This is part of #2500 that can be backported without breaking anything. None of the default system priorities are changed to preserve existing behavior, but this allows users to take advantage of setting default priority values in their own systems.

Test it

Run the UNIT_SystemManager_TEST

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This is part of #2500 that can be backported without
breaking anything. None of the default system
priorities are changed to preserve existing behavior.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 31, 2024
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scpeters scpeters merged commit 2d6a63b into gz-sim8 Oct 31, 2024
8 of 10 checks passed
@scpeters scpeters deleted the scpeters/backport_system_configure_priority branch October 31, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants