Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python bindings: get version from package.xml #556

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Similar to gazebosim/gz-math#642 using gazebosim/gz-cmake#456 from gz-cmake 4.1.0

Summary

When building python bindings separately from the main library, the major version of gz-transport has been hard-coded, but this changes it to parse the version number from the package.xml file in this repository using a gz-cmake feature added in gazebosim/gz-cmake#456 and released in 4.1.0. We could also consider using this feature in the root CMakeLists.txt file, but for now it is just used when building python bindings separately from the main library.

Test it

  1. Configure the python folder:
cd python
mkdir build
cd build
cmake ..
  1. Verify that it found gz-transport14
-- Looking for gz-transport14 -- found version 14.0.0

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Requires gz-cmake4 4.1.0.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from caguero as a code owner November 14, 2024 18:32
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Nov 14, 2024
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@scpeters scpeters merged commit 0e1a222 into gz-transport14 Nov 15, 2024
11 checks passed
@scpeters scpeters deleted the scpeters/version_from_package_xml branch November 15, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants