Build Utils examples in Bazel #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
shameekganguly
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Thanks Michael! As a general comment, I think it is not advised to set package default visibility to public: https://docs.bazel.build/versions/4.2.1/visibility.html#best-practices
For utils, I don't have a strong opinion since it has a handful of targets but for the downstream packages, I think it is better to call out the public targets.
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
…jcarroll/build_examples
I went ahead and scoped the targets back down, thanks. |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
|
@osrf-jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.