Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update launch files with name parameter #556

Merged
merged 4 commits into from
May 31, 2024
Merged

Update launch files with name parameter #556

merged 4 commits into from
May 31, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented May 31, 2024

🦟 Bug fix

A few updates we missed after #553

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero
Updating launch files.
ef08550 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero requested a review from azeey May 31, 2024 16:07
@caguero caguero requested a review from ahcorde as a code owner May 31, 2024 16:07
azeey
azeey reviewed May 31, 2024
View reviewed changes
ros_gz_bridge/launch/ros_gz_bridge.launch Outdated
@@ -1,11 +1,13 @@
<launch>
<arg name="name" default="ros_gz_bridge" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a required argument, I.e, it should not have a default value. If we do want a default value, we should consider using anon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it required to avoid user errors. 9dc4f26

caguero added 3 commits May 31, 2024 19:43
@caguero
Name is required.
9dc4f26 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Required
1c15ff2 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Restore
e3aa557 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero merged commit cadae1c into ros2 May 31, 2024
3 checks passed
@caguero caguero deleted the caguero/fix_composable_launch_part2 branch May 31, 2024 18:17
Amronos pushed a commit to Amronos/ros_gz that referenced this pull request Sep 18, 2024
@caguero @Amronos
Update launch files with name parameter (gazebosim#556)
17a1469 
* Name is required.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caguero @azeey