Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set env path #659

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Set env path #659

merged 3 commits into from
Dec 5, 2024

Conversation

Tacha-S
Copy link
Contributor

@Tacha-S Tacha-S commented Dec 3, 2024

🦟 Bug fix

Fixes #630

Summary

I set the environment variables to correctly load plugins when launching with a composable node.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Tacha-S Tacha-S requested a review from ahcorde as a code owner December 3, 2024 00:27
Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!!

This approach works, but only when using the python launch file. It wouldn't work for those using the gzserver action from XML. So, could you move these changes to the action (https://github.com/gazebosim/ros_gz/blob/ros2/ros_gz_sim/ros_gz_sim/actions/gzserver.py)?

@Amronos
Copy link
Contributor

Amronos commented Dec 3, 2024

I think this PR fixes #630 instead of #549.

Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
@Tacha-S
Copy link
Contributor Author

Tacha-S commented Dec 4, 2024

This approach works, but only when using the python launch file. It wouldn't work for those using the gzserver action from XML. So, could you move these changes to the action (ros2/ros_gz_sim/ros_gz_sim/actions/gzserver.py)?

I moved to setting environment variables in ros2/ros_gz_sim/ros_gz_sim/actions/gzserver.py.

I think this PR fixes #630 instead of #549.

Oops, it seems I accidentally selected the one above when choosing an issue.
Thank you. I’ve fixed it.

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to add some documentation about this ?

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahcorde ahcorde merged commit 0eae6ff into gazebosim:ros2 Dec 5, 2024
3 of 4 checks passed
@ahcorde
Copy link
Collaborator

ahcorde commented Dec 5, 2024

https://github.com/Mergifyio backport jazzy

Copy link
Contributor

mergify bot commented Dec 5, 2024

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 5, 2024
Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
(cherry picked from commit 0eae6ff)
@mergify mergify bot mentioned this pull request Dec 5, 2024
8 tasks
ahcorde pushed a commit that referenced this pull request Dec 6, 2024
Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
(cherry picked from commit 0eae6ff)

Co-authored-by: Tatsuro Sakaguchi <tacchan.mello.ioiq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

gzserver Does not Find Some Gazebo Plugins
4 participants