Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] remove absolute path #1310

Closed
wants to merge 1 commit into from

Conversation

talregev
Copy link

remove absolute path.

Signed-off-by: Tal Regev <tal.regev@gmail.com>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 20, 2023
@azeey
Copy link
Collaborator

azeey commented Aug 22, 2023

There's some ongoing work to make gazebo libraries relocatable. I believe the plan is to apply the same changes that were made in other libraries to libsdformat.

@azeey azeey removed their request for review August 22, 2023 17:45
@traversaro
Copy link
Contributor

Yes, a proper fix is to do here what have been done in other Gazebo libraries (see links in gazebosim/gz-sim#626 (comment)), just removing the use of the hardcoded installation prefix may break existing workflows.

@talregev
Copy link
Author

@azeey @traversaro
Should I close this PR?

@azeey
Copy link
Collaborator

azeey commented Aug 22, 2023

Yes, I think it's best to close this.

@talregev talregev closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants