overlay-tree: allow resumable runs #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
commented
Jul 1, 2023
| var ( | ||
| dbKeyOverlayTransitionStarted = []byte("overlay-transition-started") | ||
| dbKeyOverlayTransitionEnded = []byte("overlay-transition-ended") | ||
| translatedRootPrefix = []byte("translated-") |
There was a problem hiding this comment.
This is the db key prefix for saving the root translation table.
Comment on lines
-316
to
+338
| fdb.translatedRoots[fdb.translationIndex] = trans | ||
| fdb.origRoots[fdb.translationIndex] = orig | ||
| fdb.translationIndex = (fdb.translationIndex + 1) % len(fdb.translatedRoots) | ||
| fdb.diskdb.Put(append(translatedRootPrefix, orig.Bytes()...), trans.Bytes()) | ||
| log.Info("Saved translation", "originRoot", orig.Bytes(), "translatedRoot", trans.Bytes()) |
There was a problem hiding this comment.
Instead of writing to the map, we save into the database.
I left an extra log-info since it can help a bit after when something doesn't work.
Comment on lines
+345
to
347
| if err != nil { | ||
| return common.Hash{} | ||
| } |
There was a problem hiding this comment.
Technically speaking, this is equivalent to before. If Get returns err=leveldb.NotFound it returns common.Hash{} as before.
There's an extra border-case here if the err is related to a disk error. Very low chance for now to care about, but that needs bubbling some error in the chain. Not sure if this code will stay for long, but we can properly handle and clean up after.
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
force-pushed
the
jsign-resumable-run
branch
from
df2db38
to
9eec7ab
Compare
|
See #440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to collect all needed changes to allow to resume a run of an overlay tree chain importing:
startedandendedmarkers.The goal is to allow:
There's a reasonable chance that something else might be missing or needs to be fixed in this branch, since I've confirmed that as is it doesn't fully work reading the right snapshot on the second run.
Note that this PR is targeting
reenable-snapshotsas expected.