Merge pull request #134 from gcanti/133

change `Array.snoc` fix #133
gcanti · Jun 21, 2017 · 1855de3 · 1855de3
2 parents 888349d + a0e5d3f
commit 1855de3
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,11 @@
 **Note**: Gaps between patch versions are faulty/broken releases.
 **Note**: A feature tagged as Experimental is in a high state of flux, you're at risk of it changing without notice.
 
+# 0.3.4
+
+- **Bug Fix**
+  - `Array.snoc` returns wrong results with nested arrays, fix #133 (@gcanti)
+
 # 0.3.3
 
 - **New Feature**

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "fp-ts",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "description": "Functional programming in TypeScript",
   "files": [
     "lib"

diff --git a/src/Array.ts b/src/Array.ts
@@ -119,7 +119,7 @@ export function cons<A>(a: A, as: Array<A>): Array<A> {
 }
 
 export function snoc<A>(as: Array<A>, a: A): Array<A> {
-  return as.concat(a)
+  return as.concat([a])
 }
 
 export function head<A>(as: Array<A>): Option<A> {

diff --git a/test/Array.ts b/test/Array.ts
@@ -41,10 +41,12 @@ describe('Array', () => {
 
   it('cons', () => {
     assert.deepEqual(array.cons(0, as), [0, 1, 2, 3])
+    assert.deepEqual(array.cons([1], [[2]]), [[1], [2]])
   })
 
   it('snoc', () => {
     assert.deepEqual(array.snoc(as, 4), [1, 2, 3, 4])
+    assert.deepEqual(array.snoc([[1]], [2]), [[1], [2]])
   })
 
   it('curriedSnoc', () => {