Skip to content

Commit

Permalink
implemented review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
cn337131 committed Aug 17, 2023
1 parent 3a0dc81 commit d25d4a0
Show file tree
Hide file tree
Showing 8 changed files with 91 additions and 713 deletions.
2 changes: 1 addition & 1 deletion docs/dev/docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ Please note that some of these containers will only be useful if utilised by the

## Requirements

Before you can build and run these containers you will need to install Docker along with the compose plugin. Information on how to do this can be found in the [docker docs](https://docs.docker.com/get-docker/).
Before you can build and run these containers you will need to install Docker or a compatible equivalent (e.g. Podman).
6 changes: 2 additions & 4 deletions docs/dev/kubernetes-guide/add-libraries.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ By default with the Gaffer deployment you get access to the:

If you want more libraries than this (either one of ours of one of your own) you will need to customise the docker images and use them in place of the defaults.

You will need a basic Gaffer instance deployed on Kubernetes, [here](deploy-empty-graph.md) is how you do that.
You will need a [basic Gaffer instance deployed on Kubernetes](deploy-empty-graph.md).

## Overwrite the REST war file

Expand Down Expand Up @@ -49,9 +49,7 @@ docker build -t custom-gaffer-accumulo:latest .

# Switch the images in the deployment

You will need a way of making the custom images visible to the kubernetes cluster. With EKS, you can do this by uploading the images to ECR. There is an example for how to do that in one of our [other guides](aws-eks-deployment.md). With KinD, you just run `kind load docker-image <image:tag>`.

Once visible you can switch them out. Create a `custom-images.yaml` file with the following contents:
You will need a way of making the custom images visible to the kubernetes cluster. Once visible you can switch them out. Create a `custom-images.yaml` file with the following contents:

```yaml
api:
Expand Down
299 changes: 0 additions & 299 deletions docs/dev/kubernetes-guide/aws-eks-deployment.md

This file was deleted.

2 changes: 1 addition & 1 deletion docs/dev/kubernetes-guide/change-graph-metadata.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

By default, the default Gaffer deployment ships with the Graph name "simpleGraph" and description "A graph for demo purposes" These are just placeholders and can be overwritten. This guide will show you how.

The first thing you will need to do is [deply an empty graph](deploy-empty-graph.md).
The first thing you will need to do is [deploy an empty graph](deploy-empty-graph.md).

## Changing the description

Expand Down
2 changes: 1 addition & 1 deletion docs/dev/kubernetes-guide/deploy-schema.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Gaffer uses schema files to describe the data contained in a Graph. This guide will tell you how to deploy your own schemas with a Gaffer Graph.

The first thing you will need to do is deploy a simple graph. We have a guide for how to do that [here](deploy-empty-graph.md).
You will first need [a basic Gaffer instance deployed on Kubernetes] (deploy-empty-graph.md).

Once you have that deployed we can change the schema.

Expand Down
Loading

0 comments on commit d25d4a0

Please sign in to comment.