Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-210: add doc for gaffer docker #371

Merged
merged 9 commits into from
Aug 29, 2023

Conversation

cn337131
Copy link
Member

@cn337131 cn337131 commented Aug 17, 2023

Migrated READMEs and other documentation covering Docker and Kubernetes from Gaffer Docker repo.

Related Issue

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main change I'd like is reverting the reformatting to mkdocs.yml as this will disrupt other PRs. See inline comments for other details.

mkdocs.yml Outdated Show resolved Hide resolved
docs/dev/docker.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/add-libraries.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/aws-eks-deployment.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/add-libraries.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/change-graph-metadata.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/deploy-schema.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/kind-deployment.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/kubernetes.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/kubernetes.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/add-libraries.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/kubernetes.md Outdated Show resolved Hide resolved
docs/dev/kubernetes-guide/kubernetes.md Outdated Show resolved Hide resolved
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

docs/dev/kubernetes-guide/kubernetes.md Outdated Show resolved Hide resolved
@GCHQDeveloper314 GCHQDeveloper314 merged commit bce9f95 into v2docs Aug 29, 2023
1 check passed
@GCHQDeveloper314 GCHQDeveloper314 deleted the gh-210-add-doc-for-gaffer-docker branch August 29, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add doc for Gaffer-Docker
4 participants