Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-374: Add details of cache suffixes to changelog #373

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Gh-374: Add details of cache suffixes to changelog #373

merged 4 commits into from
Sep 6, 2023

Conversation

GCHQDev404
Copy link
Contributor

No description provided.

l46978
l46978 reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@l46978 l46978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this not be better in the Cache? We should probably review the branching strategy as this isn't technically part of the Gaffer 2.0.0 release.

@GCHQDeveloper314
Copy link
Member

The cache suffix as a concept is part of the Gaffer 2.0 release.
The Cache page also needs more information to be migrated from the old docs. When that is done this can also be added to that page or moved to that page potentially and linked from the changelog.

@GCHQDeveloper314 GCHQDeveloper314 linked an issue Aug 22, 2023 that may be closed by this pull request
Add details of cache suffixes to changelog #374
Closed
@GCHQDeveloper314 GCHQDeveloper314 changed the title Update federation-changes.md with Cache Suffix Gh-374: Add details of cache suffixes to changelog Aug 22, 2023
@GCHQDeveloper314
Copy link
Member

We may want to separate the part of this PR relating to features which are not in the Gaffer 2.0.0 release into a separate PR. This can be decided once the content of the 2.1.0 release is better understood - this may not be for a while.

GCHQDeveloper314
GCHQDeveloper314 reviewed Sep 5, 2023
View reviewed changes
docs/gaffer2.0/federation-changes.md Outdated Show resolved Hide resolved
docs/gaffer2.0/federation-changes.md Outdated Show resolved Hide resolved
docs/gaffer2.0/federation-changes.md Outdated Show resolved Hide resolved
@GCHQDeveloper314 GCHQDeveloper314 merged commit 2ad8f0e into v2docs Sep 6, 2023
1 check passed
@GCHQDeveloper314 GCHQDeveloper314 deleted the GCHQDev404-patch-1 branch September 6, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l46978 l46978 l46978 left review comments

@GCHQDeveloper314 GCHQDeveloper314 GCHQDeveloper314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add details of cache suffixes to changelog
3 participants
@GCHQDev404 @GCHQDeveloper314 @l46978