Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

Migrate to v0.31.0-rc5 #57

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Migrate to v0.31.0-rc5 #57

merged 1 commit into from
Jun 2, 2024

Conversation

slowsage
Copy link
Contributor

Followed this guide using the codemod.
All unit tests pass.

@slowsage slowsage marked this pull request as ready for review May 28, 2024 08:16
@slowsage slowsage marked this pull request as draft May 28, 2024 08:28
@slowsage slowsage marked this pull request as ready for review May 28, 2024 10:32
@gcornut
Copy link
Owner

gcornut commented May 29, 2024

Thanks ! I'll give it a look this week

@slowsage
Copy link
Contributor Author

Feel free to make changes as appropriate to this PR since it will likely need a new version number as it will be a breaking change. I have allowed edits by maintainers. Thank you!

git clone -b valibot-v31 git@github.com:slowsage/valibot-json-schema.git

@gcornut
Copy link
Owner

gcornut commented Jun 2, 2024

Only had to do small changes

  • TS type fix on utils/valibot isSchema
  • Reduced repetition on object schema conversion
  • Added some test case

Thanks again for this. I'll merge this and publish a RC version on NPM

@gcornut gcornut merged commit 7a7e93b into gcornut:main Jun 2, 2024
3 checks passed
@gcornut
Copy link
Owner

gcornut commented Jun 2, 2024

Actually I already have automatic snapshot build on each push to master so I probably won't create an RC

This code is available in @gcornut/valibot-json-schema@v0.30.0-snapshot.0 and up
Edit: sorry it's @gcornut/valibot-json-schema@v0.0.30-snapshot.0 and up

@slowsage
Copy link
Contributor Author

slowsage commented Jun 2, 2024

The snapshot version is set to 0.0.30 not 0.30.0. Breaks >=.
Edit: Never mind. 0.0.30 is consistent with the prior versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants