Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working reverse AD and more efficient forward-backward #33

Merged
merged 4 commits into from
Sep 10, 2023

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Sep 10, 2023

Writing down the computations allowed for faster code and working chain rules

  • Add one page of docs on scaled forward-backward and its gradients
  • Add working loglikelihood gradient computation in ChainRulesCore extension
  • (breaking) Move alpha and beta out of public API
  • Add more tests of interface and correctness
  • Stop testing on nightly

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage: 98.19% and project coverage change: +0.30% 🎉

Comparison is base (bca1bab) 93.16% compared to head (dd8714c) 93.47%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   93.16%   93.47%   +0.30%     
==========================================
  Files          19       18       -1     
  Lines         483      521      +38     
==========================================
+ Hits          450      487      +37     
- Misses         33       34       +1     
Files Changed Coverage Δ
src/inference/viterbi.jl 95.45% <ø> (ø)
src/types/abstract_hmm.jl 90.90% <ø> (ø)
src/inference/forward.jl 92.15% <88.23%> (ø)
ext/HiddenMarkovModelsChainRulesCoreExt.jl 100.00% <100.00%> (ø)
src/HiddenMarkovModels.jl 100.00% <100.00%> (ø)
src/inference/baum_welch.jl 90.69% <100.00%> (ø)
src/inference/forward_backward.jl 96.93% <100.00%> (+1.35%) ⬆️
src/types/abstract_mc.jl 97.29% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 9ded022 into main Sep 10, 2023
5 checks passed
@gdalle gdalle deleted the finish_chain_rules branch September 10, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant