Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entry): remove valid() method #17

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

janrnc
Copy link
Member

@janrnc janrnc commented Nov 11, 2023

Return an error instead of creating invalid entries when running out of IDs.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #17 (be8677e) into master (13f4603) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   95.73%   95.90%   +0.17%     
==========================================
  Files           7        7              
  Lines         656      659       +3     
==========================================
+ Hits          628      632       +4     
+ Misses         24       23       -1     
  Partials        4        4              
Files Coverage Δ
cron.go 93.04% <100.00%> (+0.65%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@janrnc janrnc force-pushed the feat/remove-valid-method branch from 069897d to fca5ecc Compare November 11, 2023 11:12
@janrnc janrnc force-pushed the feat/remove-valid-method branch from fca5ecc to 4079229 Compare November 11, 2023 11:17
@janrnc janrnc changed the title feat(Entry): remove valid method feat(entry): remove valid() method Nov 11, 2023
@janrnc janrnc force-pushed the feat/remove-valid-method branch from 1549283 to be8677e Compare November 11, 2023 11:35
@janrnc janrnc merged commit abf1acd into gdgvda:master Nov 11, 2023
5 checks passed
@janrnc janrnc linked an issue Nov 11, 2023 that may be closed by this pull request
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@janrnc janrnc deleted the feat/remove-valid-method branch September 10, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entry validity check refactor
1 participant