Adding MacOS App #364
Open
Adding MacOS App #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disconnect. Copy paste is available on preference.
|
This has been around for some time. Will this ever be merged and released? |
|
@gdombiak will this be added to the codebase eventually? If not (for whatever reason) maybe you could remove/deny the pull request. |
|
Hi @vordenken, I'm still interested in incorporating this PR. Both @ariforu and I need to find time to finish the merge. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gdombiak This pull request contains the code for new MacOS app. It altered some of the common codebase to make the APIs compliant with MacOS APIs. Because of that changes must be tested in other devices(iPhone, Watch, TV). Also since we are using Personal Apple accounts, the team names had to be changed to make the app compile in my machine. You'll have to change it back.
See #288