Explicitely define namespace #71
Conversation
|
Now it "works for me" - my current setup is Android 13 with grocy (see patzly/grocy-android#771). |
|
Anyways thanks for your library which also inspired me to write https://github.com/stephanritscher/InteractiveKeyManager |
|
FWIW, I also come up with the same adjustments to target modern Android APIs. @ge0rg please consider merging this PR, thanks. |
| final PendingIntent call = PendingIntent.getActivity(master, 0, intent, | ||
| 0); | ||
| final PendingIntent call; | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) { |
There was a problem hiding this comment.
I would factor out the API relevant part instead of the whole getActivity() call.
int flags = 0;
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
flags |= PendingIntent.FLAG_MUTABLE
}
call = PendingIntent.getActivity(master, 0, intent, flags);There was a problem hiding this comment.
Actually, are you sure that the flag must be mutable and not immutable? I don't see why the pending intent's data should be mutable.
If it's immutable then we could simply unconditionally append FLAG_IMMUTABLE:
There was a problem hiding this comment.
I'm pretty sure it didn't work without that flag, but I'm not quite sure if I tried to add the opposite flag. Would be worth a shot, but it would take me some time...
| @@ -1,6 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
| package="de.duenndns.ssl" | |||
| android:versionCode="1" | |||
There was a problem hiding this comment.
Moving the package declaration from the manifest into the gradle build description should be a atomic commit. Consider adding this change to d98391c
stephanritscher
force-pushed
the
master
branch
from
e0fcfe2
to
c1296be
Compare
stephanritscher
force-pushed
the
master
branch
from
c1296be
to
79decf2
Compare
It seems that is requires for submodules with gradle 8.1.0.