Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the code base #75

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Modernize the code base #75

merged 5 commits into from
Dec 19, 2023

Conversation

geigerzaehler
Copy link
Owner

A couple of modernizations for the code base in separate commits

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
@wisp3rwind
Copy link
Collaborator

Oh, wow, I didn't realize we still depended on six here. Thanks for finally wrapping up the Python 3 transition!

I guess the new assert statements are there to calm the type checker?

Otherwise, looks at a quick glance 👍

Regarding the Python 3.13 failures, cf. beetbox/mediafile#67

@geigerzaehler geigerzaehler marked this pull request as ready for review December 18, 2023 07:49
@geigerzaehler
Copy link
Owner Author

Oh, wow, I didn't realize we still depended on six here.

Yeah, I had always put this off because I thought it would be more effort.

I guess the new assert statements are there to calm the type checker?

Yes

@geigerzaehler geigerzaehler merged commit 1032756 into main Dec 19, 2023
7 of 9 checks passed
@geigerzaehler geigerzaehler deleted the g/modernize branch December 19, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants