Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on linux and mac using also python 3.8 and 3.9 #9028

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Conversation

ptormene
Copy link
Member

This is just to trigger a full run of tests on linux

@ptormene ptormene self-assigned this Sep 22, 2023
@micheles
Copy link
Contributor

micheles commented Sep 25, 2023

The tests here must run ONLY during the night, not at every pull request thus tripling the runtime without any good reason.

@ptormene
Copy link
Member Author

Yes, my comment on top was cryptical, but what I meant was that I needed to open a draft PR in order to trigger the action right away and check that also python3.8 and 3.9 were ok. Then my intention is to have two very similar yml files, one running only on python3.10 at each PR (using -x) and one running also on 3.8 and 3.9 scheduled to run every night (without -x, so all errors are listed).

@ptormene
Copy link
Member Author

ptormene commented Sep 26, 2023

Summarizing:

@ptormene ptormene marked this pull request as ready for review September 26, 2023 12:23
@micheles
Copy link
Contributor

Ah, thanks @ptormene , then LGTM.

@ptormene ptormene added this to the Engine 3.18.0 milestone Sep 27, 2023
@micheles micheles merged commit 18546d1 into master Sep 27, 2023
@micheles micheles deleted the py38and39 branch September 27, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants