Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logout from the Programs popup. #3362

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

toddburnside
Copy link
Contributor

This PR adds a Logout button the the Programs popup if you reached the popup due to a missing or invalid program id in the url.
image
It also moves the popup code for missing or invalid programs out of the routing code and into ExploreLayout.

@shortcut-integration
Copy link

@mergify mergify bot added the explore label Oct 13, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7e3b5d3) 31.24% compared to head (207284a) 31.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3362   +/-   ##
=======================================
  Coverage   31.24%   31.24%           
=======================================
  Files          78       78           
  Lines        1895     1895           
  Branches       30       30           
=======================================
  Hits          592      592           
  Misses       1303     1303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bundlemon
Copy link

bundlemon bot commented Oct 13, 2023

BundleMon

Files updated (2)
Status Path Size Limits
index-(hash).js
1.7MB (+745B +0.04%) -
exploreworkers-(hash).js
729.51KB (-185B -0.02%) -
Unchanged files (6)
Status Path Size Limits
index-(hash).css
60.41KB -
workbox-window.prod.es5-(hash).js
1.82KB -
agsworker-(hash).js
75B -
itcworker-(hash).js
75B -
plotworker-(hash).js
75B -
catalogworker-(hash).js
73B -

Total files change +560B +0.02%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@toddburnside toddburnside merged commit 6dbd46f into master Oct 13, 2023
@toddburnside toddburnside deleted the sc-2525-program-popup-logout branch October 13, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants