Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Now button to obs time #4035

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Add Now button to obs time #4035

merged 2 commits into from
Aug 1, 2024

Conversation

rpiaggio
Copy link
Contributor

@rpiaggio rpiaggio commented Aug 1, 2024

image

cquiroz
cquiroz reviewed Aug 1, 2024
View reviewed changes
explore/src/main/scala/explore/config/ObsTimeEditor.scala Outdated
ScalaFnComponent
.withHooks[Props]
.useRef[Option[ReactDatePicker[Any, Any]]](none)
// .useRefToJsComponentWithMountedFacade[js.Object, js.Object, js.Object]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented code

cquiroz
cquiroz approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bundlemon BundleMon
Copy link

bundlemon bot commented Aug 1, 2024

BundleMon

Files updated (2)
Status Path Size Limits
✅ index-(hash).css
 65.43KB (+55B +0.08%) -
✅ index-(hash).js
 1.66MB (-821B -0.05%) -
Unchanged files (6)
Status Path Size Limits
✅ exploreworkers-(hash).js
 602.34KB -
✅ workbox-window.prod.es5-(hash).js
 2.07KB -
✅ agsworker-(hash).js
 85B -
✅ plotworker-(hash).js
 84B -
✅ catalogworker-(hash).js
 82B -
✅ itcworker-(hash).js
 81B -

Total files change -766B -0.03%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@rpiaggio rpiaggio merged commit 39dce9a into master Aug 1, 2024
14 checks passed
@rpiaggio rpiaggio deleted the sc-3269-support-setting-observation-time-to-now branch August 1, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
common explore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpiaggio @cquiroz @toddburnside