Prevent asterism updates for executed observations, add undo/redo #4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (1)
Unchanged files (7)
Total files change +1.47KB +0.06% Final result: ✅ View report in BundleMon website ➡️ |
toddburnside
force-pushed
the
protect-asterism
branch
from
20038dd to
807e16f
Compare
cquiroz
reviewed
Aug 14, 2024
| @@ -20,4 +20,25 @@ object AsterismQueriesGQL { | |||
| } | |||
| """ | |||
| } | |||
|
|
|||
| // Group these 2 mutations together so that the targetEdit and observationEdit subscriptions come | |||
There was a problem hiding this comment.
Is this guaranteed to work?
There was a problem hiding this comment.
Well, we reduce the transit time involved, but they still aren't real close together. That timing depends on when the database updates happen for the 2 mutations, I guess. Still seemed better than doing them individually. 🤷♂️
cquiroz
reviewed
Aug 14, 2024
| @@ -59,6 +59,7 @@ object AsterismEditorTile: | |||
| backButton: Option[VdomNode] = none | |||
| )(using FetchClient[IO, ObservationDB], Logger[IO]): Tile = { | |||
| // Save the time here. this works for the obs and target tabs | |||
| // It's OK to save the viz time for executed observations, I think. | |||
| val vizTimeView = | |||
| vizTime.withOnMod(t => ObsQueries.updateVisualizationTime[IO](obsIds.toList, t).runAsync) | |||
There was a problem hiding this comment.
This needs an update I think
There was a problem hiding this comment.
Actually, it looks like it is still called ObsQueries.updateVisualizationTime in your PR. 😄 So, I don't think this needs to change. Unless there is another reason.
cquiroz
approved these changes
Aug 14, 2024
toddburnside
force-pushed
the
protect-asterism
branch
from
807e16f to
6fa38f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.