Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acquisition steps are optional #4255

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Acquisition steps are optional #4255

merged 1 commit into from
Oct 25, 2024

Conversation

cquiroz
Copy link
Contributor

@cquiroz cquiroz commented Oct 25, 2024

No description provided.

@mergify mergify bot added the model label Oct 25, 2024
rpiaggio
rpiaggio approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@rpiaggio rpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

toddburnside
toddburnside approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@toddburnside toddburnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 25, 2024

BundleMon

Files updated (1)
Status Path Size Limits
✅ index-(hash).js
 1.73MB (+1.18KB +0.07%) -
Unchanged files (7)
Status Path Size Limits
✅ exploreworkers-(hash).js
 606.18KB -
✅ index-(hash).css
 65.91KB -
✅ workbox-window.prod.es5-(hash).js
 2.07KB -
✅ itcworker-(hash).js
 87B -
✅ catalogworker-(hash).js
 82B -
✅ plotworker-(hash).js
 79B -
✅ agsworker-(hash).js
 75B -

Total files change +1.18KB +0.05%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@cquiroz cquiroz merged commit 6c308ae into master Oct 25, 2024
16 checks passed
@cquiroz cquiroz deleted the sc-3838-acquisiton-is-null-for-twilights branch October 25, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpiaggio rpiaggio rpiaggio approved these changes

@toddburnside toddburnside toddburnside approved these changes

Assignees
No one assigned
Labels
model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cquiroz @rpiaggio @toddburnside