Elevation plots in observation summary #4262
Conversation
USERPREFS.md
Outdated
| You can spin up a server that servers a console app for an environment by using the CLI from the `hasura/user-prefs` directory. For example: | ||
|
|
||
| ``` | ||
| hasura console --endpoint https://user-prefs-development.herokuapp.com |
There was a problem hiding this comment.
maybee we should recommend using master
There was a problem hiding this comment.
good point, I'll change it
BundleMonFiles updated (1)
Unchanged files (7)
Total files change +188B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
| @@ -64,7 +64,8 @@ | |||
| } | |||
|
|
|||
| .rgl-tile-overlay { | |||
| display: none; /* Enable for grid debugging */ | |||
| display: none; | |||
There was a problem hiding this comment.
It's removed, but prettier doesn't let me put the comment in the same line anymore.
|
Could you squash the migrations? |
| @@ -269,6 +270,40 @@ object ExploreGridLayouts: | |||
| ).withMinWidth | |||
| end observations | |||
|
|
|||
| object observationList: | |||
There was a problem hiding this comment.
Because the observation tree on the left is still name ObsList, I wonder if this should be named something like observationSummary for clarity?
There was a problem hiding this comment.
observationSummary is just the tile, not the view with the tile+plot. I'd rather change ObsList to ObsTree
rpiaggio
deleted the
sc-3334-observation-summary-table-improvements-part-2
branch
|
I just realized that the Hasura migration is missing from this PR. Hasura Console seems to create it (which I checked) but then deletes it after a few seconds, for some mysterious reason unknown to mere mortals. I will add it to the next PR. |
A new layout id is now used for the observation summary+plot. I renamed some tile ids so as to have a unified naming scheme, hence the large number of changed files.